aboutcode-org / aboutcode-org/scancode-toolkit

Wrong detection for Apple MFi License as apple-excl

Open
#2,503 1 comment 1 reaction 0 assignees View on GitHub
bug license scan new and improved data
Dominant language
Python
Stars
2.6k
Forks
791
Avg merge
1d 12h
Merged PRs (30d)
5

Description

We got some SDK provided by Apple under NDA under the MFi License.

This is a proprietary license with very similar wording as other Apple licenses, except you can't redistribute source (only binary)

I am not sure I can disclose the full text of the license in the open, I found a few exemples of similar files.
I am not sure I want to link there as they are probably illegal copies, but google will find it quite easily using search term:

WAC_POSIX_Server_1.22/Makefile

This license is detected be apple-excl, with following matches:

```
[LicenseMatch: '2-aho', lines=(9, 9), 'license-intro_35.RULE',
'unknown-license-reference',
sc=100.0, cov=100.0, len=6, hilen=0, rlen=6, qreg=(47, 52), ireg=(0, 5), LicenseMatch: '3-seq', lines=(11, 28), 'apple-excl.LICENSE',
'apple-excl',
sc=51.85, cov=51.85, len=182, hilen=40, rlen=351, qreg=(75, 313), ireg=(16, 221), LicenseMatch: '3-seq', lines=(39, 49), 'apple-excl.LICENSE',
'apple-excl',
sc=36.75, cov=36.75, len=129, hilen=29, rlen=351, qreg=(418, 546), ireg=(222, 350)]
```

apple-excl is classified permissive, which is not the case at all with MFi License, so we probably need to take care of this false positive

After a quick search on the closed issue list, it looks like my team mate @vbisserie already reported this during my vacations, but in my opinion closed it a bit too early.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.