aboutcode-org / aboutcode-org/purldb

test_package_endpoint_throttling fails with 429 instead of expected 200

Open
#849 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
HTML
Stars
67
Forks
69
Avg merge
8d 8h
Merged PRs (30d)
1

Description

## Summary
`test_package_endpoint_throttling` in `packagedb/tests/test_throttling.py`
is consistently failing with a `429 Too Many Requests` response when
the test expects a `200 OK`.

## Steps to Reproduce
Run the test suite:
```bash
python manage_purldb.py test packagedb.tests.test_throttling
```

## Expected Behavior
The test should return `200 OK` as the throttle limit should not
be triggered during a controlled test environment.

## Actual Behavior
```
FAIL: test_package_endpoint_throttling
AssertionError: 429 != 200
```

## Root Cause (suspected)
The throttle rate counter is likely not being reset between test runs,
causing requests from previous tests to count toward the throttle limit.
This means by the time `test_package_endpoint_throttling` runs, the
throttle has already been triggered.

## Possible Fix
- Override `DEFAULT_THROTTLE_RATES` to `None` or a high value in test settings
- Or explicitly reset the throttle cache between tests using
`cache.clear()` in the test `setUp()` method

## Environment
- Python 3.13
- Django test runner via `manage_purldb.py`

## References
- Related to throttling logic in `packagedb/throttling.py`
- Test file: `packagedb/tests/test_throttling.py`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.