aboutcode-org / aboutcode-org/pip-requirements-parser

[BUG] VCS URLs are detected as path on linux systems

Ouverte
#24 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Python
Étoiles
20
Forks
13
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

# issue
`'git+https://github.com/path/to/package-one@41b95ec#egg=package-one'`
is detected as a path, but actually it is just a VCS url

# expected:

`'git+https://github.com/path/to/package-one@41b95ec#egg=package-one'`
is NOT detected as a path

# reason:
```py
def _looks_like_path(name: str) -> bool:
"""Checks whether the string ``name`` "looks like" a path on the filesystem.

This does not check whether the target actually exists, only judge from the
appearance.

Returns true if any of the following conditions is true:
* a path separator is found (either os.path.sep or os.path.altsep);
* a dot is found (which represents the current directory).
"""
if not name:
return False
if os.path.sep in name:
return True
# exists here, on linux/unix, as there is a '/' in the name
# ...
```

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.