abcxyz / abcxyz/jvs

Use real services for integration test

Open
#158 2 comments 0 reactions 1 assignee Claimed by @sqin2019 View on GitHub
cleanup test
Dominant language
Go
Stars
8
Forks
1
PR merge metrics
No merged PRs in 30d

Description

At the moment, we don't run _real_ services in integration tests. Instead, we launch services in Go tests. This is not ideal since it doesn't provide test coverage on the real container images we release.

Per https://github.com/abcxyz/jvs/pull/157, we had a bug in the dockerfile that caused bad container images. The integration test didn't catch that and we only realized the issue when we were trying to deploy the images.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.