aave / aave/interface

Aave swap allow wrong swap

Open
#2,522 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug new issue
Dominant language
TypeScript
Stars
536
Forks
496
Avg merge
1d 8h
Merged PRs (30d)
9

Description

Describe the bug
Aave swap module propose some swap that must not be available. Example swaping sDAI collateral to EURe.

If asset is disabled as collateral the module must not display then or at least the swap bouton must be disabled

To Reproduce
Steps to reproduce the behavior:

Try to swap current collateral that back a loan for an asset who have LTV to 0

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Aave swap module and reproduce a swap from collateral backing a loan into an asset with LTV 0, such as sDAI to EURe. Trace how eligible assets and the swap button are determined; done means disabled-collateral swaps are not offered or cannot be initiated.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.