aasm / aasm/aasm

Whiny_persistence should be true as default

Open
#780 3 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
5.2k
Forks
644
PR merge metrics
No merged PRs in 30d

Description

Is your feature request related to a problem? Please describe.
I wasn't aware that the events with bangs didn't raise an error when validation fails.

This is unconsistent with ActiveRecord methods' behaviour.

Describe the solution you'd like

  1. Whiny_persistence's default value should be true
  2. It should be possible to change the defaults application-wide in an initializer.

Describe alternatives you've considered
Doesn't apply

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the whiny_persistence setting and the ActiveRecord integration, then inspect how application-wide defaults are currently configured. Done means bang events raise on validation failure by default and an initializer can override that default; add or update the relevant tests for both behaviors.

Written by the indexing model from the issue text.

Assessment

Tech stack
rails, ruby
Domain
backend, databases
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.