aRustyDev / aRustyDev/pcf-mcp

Fix remaining linting errors in CI/CD pipeline

Open
#31 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

The CI/CD pipeline is now working correctly and has identified several linting errors that need to be fixed:

## Linting Errors Found:

1. **errcheck violations**: Multiple instances where error return values are not checked
- `(*encoding/json.Encoder).Encode` errors not checked
- `server.RegisterTool` errors not checked
- Other unspecified error return values not checked

2. **unused code**:
- Function `createJaegerExporter` is unused

3. **ineffassign violations**:
- Ineffectual assignment to `ctx` (multiple instances)

## Action Items:
- [ ] Fix all errcheck violations by properly handling errors
- [ ] Remove unused `createJaegerExporter` function
- [ ] Fix ineffectual assignments to `ctx`
- [ ] Ensure all tests pass after fixes
- [ ] Verify CI/CD pipeline passes all checks

These errors need to be fixed to ensure code quality and enable successful CI/CD runs.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.