aRustyDev / aRustyDev/agents

fix(validation): update naming pattern to handle edge cases (11 skills)

Open
#428 0 comments 0 reactions 1 assignee Claimed by @aRustyDev View on GitHub
bug naming validation
Dominant language
Jupyter Notebook
Stars
8
Forks
3
PR merge metrics
No merged PRs in 30d

Description

## Summary

11 non-conversion skills fail validation due to naming pattern edge cases. These fall into three categories.

## Current Pattern

```regex
^[a-z0-9]+-([a-z0-9]+-)?[a-z0-9]+-[a-z]+$
```

Expects 3-4 segments: `-[-]-`

## Failure Categories

### 1. Too Many Segments (5 segments)

These have valid focus but exceed the 3-4 segment limit:

| Skill | Segments | Focus |
|-------|----------|-------|
| `meta-context-evaluation-advanced-eng` | 5 | eng ✓ |
| `method-code-review-receiving-dev` | 5 | dev ✓ |
| `method-code-review-requesting-dev` | 5 | dev ✓ |
| `method-reproduce-reduce-regress-eng` | 5 | eng ✓ |

**Fix**: Update regex to allow more optional segments

### 2. Too Few Segments (2 segments)

These are missing category structure:

| Skill | Segments | Focus |
|-------|----------|-------|
| `openfeature-eng` | 2 | eng ✓ |
| `openmetadata-dev` | 2 | dev ✓ |
| `openmetadata-ops` | 2 | ops ✓ |

**Fix options**:
- Rename to add category (e.g., `tool-openfeature-eng` or `data-openmetadata-dev`)
- OR update regex to allow 2 segments

### 3. Invalid Focus Suffix

These use focus values not in the allowed list:

| Skill | Segments | Focus |
|-------|----------|-------|
| `meta-convert-guide` | 3 | guide ✗ |
| `openmetadata-dq` | 2 | dq ✗ |
| `openmetadata-user` | 2 | user ✗ |

**Fix options**:
- Rename to use valid focus (e.g., `meta-convert-authoring-dev`)
- OR add new focus types to allowed list (`guide`, `dq`, `user`)

## Allowed Focus Values

Current: `ops`, `dev`, `eng`, `nub`, `xec`

Consider adding:
- `guide` - educational/tutorial content
- `dq` - data quality
- `user` - end-user focused

## Proposed Regex Update

```bash
# Allow 2-5+ segments with valid focus
^[a-z0-9]+(-[a-z0-9]+)*-(ops|dev|eng|nub|xec|guide|dq|user)$
```

Or keep strict and rename the 11 skills to conform.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.