a8m / a8m/kinesis-producer

Logrus Entry vs Logger

Open
#23 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
150
Forks
47
PR merge metrics
No merged PRs in 30d

Description

To support logging already defined fields using logrus, is there any concern with switching to `Entry` rather than `Logger`?

From [logrus docs](https://github.com/sirupsen/logrus/blob/master/entry.go#L47):

```
These objects can be reused and passed around as much as you wish to avoid field duplication.
```

Add [README](https://github.com/sirupsen/logrus#default-fields)

```
Often it's helpful to have fields always attached to log statements in an application or parts of one. For example, you may want to always log the request_id and user_ip in the context of a request. Instead of writing log.WithFields(log.Fields{"request_id": request_id, "user_ip": user_ip}) on every line, you can create a logrus.Entry to pass around instead:
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.