a8m / a8m/angular-filter

Cache no longer works (angular >= 1.3)

Open
#157 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2.9k
Forks
319
PR merge metrics
No merged PRs in 30d

Description

Hey all,

Because of this line from Angular 1.2:

``` javascript
return fn.apply(self, args);
```

https://github.com/angular/angular.js/blob/g3_v1_2/src/ng/parse.js#L595

Was changed to this line in Angular 1.3:

``` javascript
return fn.apply(undefined, args);
```

https://github.com/angular/angular.js/blob/g3_v1_3/src/ng/parse.js#L568

`this` in all the filters is no longer linked to the scope that called the filter and therefor **filterWatcher** gets `scope=undefined` which causes `isScope(scope)` to always return `false` which in turn causes `cleanStateless()` to get called after every filter call, `cleanStateless()` cleans the cache.

The consequence is major performance issues and slowdown on every $digest cycle (which re-evaluates the filter output even though the input did not change).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.