a8m / a8m/angular-filter

After, Before are 1-Indexed Instead of 0-indexed

Open
#128 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2.9k
Forks
319
PR merge metrics
No merged PRs in 30d

Description

I would suggest a change, but this would break a lot of stuff. Therefore, I suggest changing the documentation to reflect that it's 1-indexed, as this is confusing and I thought it wasn't working (I was doing before:1 assuming it would give me the first item as a collection but it gave me nothing instead. Don't suggest "first," as I wanted a collection to run through a template and then had after:1 going through the same template)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.