Should geom::Polygon.points be closed or not?
- Linguagem predominante
- Rust
- Estrelas
- 2
- Forks
- 1
- Métricas de merge de PRs
- Nenhum PR com merge em 30d
Descrição
I wanted to test out some new georust/geo features in the context of abstreet, and consequently I've been spelunking in abstreet::geom.
I ran into some inconsistencies while trying to roundtrip some abstreet::geom::Polygyon to/from geo::Polygon - it resulted in some corrupt rendering like this:

My unverified hunch is that this some problem with one or more of:
- a mismatch in the `points` array and the precomputed triangulation `indices`
- an issue with the vertex uploading assuming closed vs open
- an issue with earcutr assuming closed vs open
While digging into that, I noticed that some (but not all) of the abstreet:geom::Polygon.points are closed. Do you have any strong feelings on whether abstreet::geom::Polygon.points should be closed?
Full disclosure is that more broadly I'm interested in making abstreet/geom more semantically consistent with georust/geo, in hopes of make future inter-op easier, but I'm also aware that these are the kinds of changes with no immediate benefit that could have a long tail of bugs in a system which is more or less currently working.
Guia de contribuição
Nenhum guia de contribuição indexado para este repositório
Avaliação
Esta issue ainda não foi avaliada.