a-b-street / a-b-street/abstreet

Merging blocks is lossy

Aperta
#841 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Rust
Stelle
8.2k
Fork
380
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

I spent a whole bunch of time trying to figure out why individual blocks are fine, but after partitioning and trying to merge, many of them vanish. This breaks the LTN select boundary tool. `Perimeter::merge_all` appears lossless.

I found a workaround, but I want to fix properly. At least two of the problems:
- rotating a perimeter (part of `try_to_merge`) shouldn't have an effect, but sometimes, I _think_ it does. So we have a defensive copy in `try_to_merge` now
- some blocks are fine until we collapse deadends, then they break

Two of the areas I dug into:
- Leeds north, https://www.openstreetmap.org/node/2367939954, the inner hole probably is breaking it
- Bristol, https://www.openstreetmap.org/node/1401181776, the zorder is weird to start with

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.