ZigRazor / ZigRazor/CXXGraph

Partition test is failing on windows

Open
#417 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug hacktoberfest Priority:High windows
Dominant language
C++
Stars
729
Forks
147
Avg merge
19h
Merged PRs (30d)
1

Description

          > @nolankramer I see that partition test is failing on windows, but I suppose that the issue is unrelated to this PR.

FWIW, that test has been failing for a long time. Somebody is grabbing a mutex they don't own in the partitioning code. That can likely be cleaned up in another PR.

Originally posted by @nolankramer in https://github.com/ZigRazor/CXXGraph/issues/416#issuecomment-2070978590

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the partition test failure on Windows, then inspect the partitioning code around mutex ownership. The issue mentions no file or test path, so locate the failing partition test first. Done means the test passes on Windows and the mutex ownership problem is addressed.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
data, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.