YousefED / YousefED/typescript-json-schema
noExtraProps flag not working with recursive type
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 3.3k
- Forks
- 332
- PR merge metrics
- No merged PRs in 30d
Description
Steps to Reproduce:
version: 0.59.0
create schema for Foo type, and turn on the flag noExtraProps.
interface ChildFoo {}
interface Foo {
childFoo: Foo & ChildFoo;
}
The error:
Maximum call stack size exceeded.
Because we merging the object, instead of use in allOf (see #107), in recursive type we trying to build schema for parent and child again and again.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the TypeScript example with version 0.59.0 and the noExtraProps flag, then inspect the recursive handling of the Foo and ChildFoo types. Compare the object-merging behavior with the allOf approach mentioned in #107; done means recursive types generate a schema without a maximum call stack error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100