YousefED / YousefED/typescript-json-schema

Regex for patternProperties number is incorrect

Open
#352 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
3.3k
Forks
332
PR merge metrics
No merged PRs in 30d

Description

interface Something {
  [value: number]: any;
}

Generates

"patternProperties": {
  "^[0-9.]+$": {
    ...
  }
}

The regex ^[0-9.]+$ does not account for decimals or other valid values of numbers.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the code that generates patternProperties for numeric index signatures, using the reported Something interface and its generated schema as the reproduction. Check how the current ^[0-9.]+$ pattern is defined, then validate the result against decimal and other valid numeric values while preserving the expected JSON Schema output.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.