Yoast / Yoast/duplicate-post

Clicking a link to open in a new tab still triggers unsaved changes prompt

Open
#303 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
53
Forks
38
Avg merge
4d 8h
Merged PRs (30d)
1

Description

https://yoast.atlassian.net/browse/DUPP-333

With unsaved changes, when holding ctrl (windows) or cmd (mac) and clicking a menu link or any link (to open in a new tab), the unsaved changes modal still pops up.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the linked DUPP-333 ticket and reproducing the behavior with unsaved changes. Test ctrl-click on Windows and cmd-click on macOS for menu and other links; done means opening a link in a new tab no longer triggers the unsaved changes modal while ordinary navigation remains covered.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, wordpress
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.