Yoast / Yoast/duplicate-post

Contradiction in terms when copying children

Open
#11 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
53
Forks
38
Avg merge
4d 8h
Merged PRs (30d)
1

Description

nope nope nope nope nope nope

https://github.com/enricobattocchi/duplicate-post/blob/544c9c1222c451ab8edc33aa74194e539dcb0d9f/duplicate-post-admin.php#L645

  1. User can configure what post types to clone but then it says "any" here.
  2. Imagine a Mail is the parent of a Task is the parent of multiple Time Trackings each parent of Invoice Items each parent of Payment Receipt. When I copy a Task how much is this screwed up?
  3. When solved then it should not use the current post-type options but a new one as inheritance behaviour for cross-post-type relationships is a totally different thing.
  4. Deactivating "duplicate_post_copychildren" is not a solution because the user wants to copy children (of the same type I guess).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at duplicate-post-admin.php around line 645 and trace how the configured post types relate to the “any” wording and duplicate_post_copychildren behavior. Clarify the expected handling of nested and cross-post-type child relationships, including whether inheritance needs separate options. Done means the contradictory behavior and listed relationship cases have an agreed resolution.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, wordpress
Domain
backend
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.