Xil_DCacheFlushRange() unhandled integer overflow
Open
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 1.2k
- Forks
- 1.1k
- PR merge metrics
- No merged PRs in 30d
Description
e.g. in embeddedsw/lib/bsp/standalone/src/arm/cortexr5/xil_cache.c
if adr+len > 2^32 (bad usage)
or adr+len == 2^32 (valid usage),
nothing will happen.
more dangerously, if (adr+len > 2^32 - cacheline) && (adr+len < 2^32) (also valid usage),
the while loop never terminates.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in embeddedsw/lib/bsp/standalone/src/arm/cortexr5/xil_cache.c at Xil_DCacheFlushRange(). Trace the address and length arithmetic and the while-loop termination for sums at and near 2^32. Done means the reported boundary cases are handled without silently doing nothing or entering a non-terminating loop.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- embedded-iot
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100