Possible unnecessary XCanFd_ReadReg() in XCanFd_Send()
Open
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 1.2k
- Forks
- 1.1k
- PR merge metrics
- No merged PRs in 30d
Description
The return value of XCanFd_ReadReg() is unused, Is that line necessary?
According to CAN FD v1.0 LogiCORE IP Product Guide Table 2-18 It doesn't state host reading of TX Buffer Ready Request Register affects anything.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in XilinxProcessorIPLib/drivers/canfd/src/xcanfd.c at line 462 within XCanFd_Send(), then consult CAN FD v1.0 LogiCORE IP Product Guide Table 2-18. Trace whether the XCanFd_ReadReg() return value or read side effect is used elsewhere. Done means the necessity of the read is established and the issue's proposed cleanup is resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- embedded-iot
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100