Xilinx / Xilinx/embeddedsw

xdp_intr.c is missing a few function definitions in the header

Open
#294 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
HTML
Stars
1.2k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

The following functions are missing inside of xdp.h

void XDp_RxInterruptEnable1(XDp *InstancePtr, u32 Mask)
https://github.com/Xilinx/embeddedsw/blob/master/XilinxProcessorIPLib/drivers/dp14/src/xdp_intr.c#L194

void XDp_RxInterruptDisable1(XDp *InstancePtr, u32 Mask)
https://github.com/Xilinx/embeddedsw/blob/master/XilinxProcessorIPLib/drivers/dp14/src/xdp_intr.c#L223

It looks like these should be declared, as they are used in the displayport examples, but wont compile in C++

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the declarations in XilinxProcessorIPLib/drivers/dp14/src/xdp.h with the definitions in xdp_intr.c at lines 194 and 223. Confirm how the displayport examples call these functions and verify that the header exposes both declarations so the examples compile as C++.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, cpp
Domain
embedded-iot
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.