Xilinx / Xilinx/embeddedsw

Several files will not compile for C++

Open
#293 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
HTML
Stars
1.2k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

When attempting to compile our project in C++ against the embeddedsw repo, there are several headers that cause build failures. The ones we have run into are as follows:

  • xdp.h: Missing extern "C" {}
  • xdp_hw.h: Missing extern "C" {}
  • xv_tpg.h: _Bool is not defined, had to include stdbool.h to solve this. Shouldnt this just match what other functions have done (use u8?).
  • i2stx_chsts.h: Missing the closing brace for the extern "C"
  • i2srx_chsts.h: Missing the closing brace for the extern "C"

We have patched it on our end, but it would be greatly appreciated for these to be fixed upstream.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with xdp.h, xdp_hw.h, xv_tpg.h, xi2stx_chsts.h, and xi2srx_chsts.h in the linked driver paths, then reproduce the reported C++ compilation failures against embeddedsw. Check the extern "C" boundaries and the _Bool declaration described in the issue. Done means all listed headers compile successfully for C++ without local patches.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
embedded-iot
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.