Xilinx / Xilinx/embeddedsw

Error in XDfePrach_GetEventStatus

Open
#219 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
HTML
Stars
1.2k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

In this function, the second of these two assigns is wrong:

Status->FrameInitTrigger =
	XDfePrach_RdBitField(XDFEPRACH_FRAME_INIT_TRIGGERED_WIDTH,
			     XDFEPRACH_FRAME_INIT_TRIGGERED_OFFSET,
			     Val);
Status->FrameInitTrigger = XDfePrach_RdBitField(
	XDFEPRACH_FRAME_ERROR_WIDTH, XDFEPRACH_FRAME_ERROR_OFFSET, Val);

It should be:

Status->FrameInitTrigger =
	XDfePrach_RdBitField(XDFEPRACH_FRAME_INIT_TRIGGERED_WIDTH,
			     XDFEPRACH_FRAME_INIT_TRIGGERED_OFFSET,
			     Val);
Status->FrameError= XDfePrach_RdBitField(
	XDFEPRACH_FRAME_ERROR_WIDTH, XDFEPRACH_FRAME_ERROR_OFFSET, Val);

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the XDfePrach_GetEventStatus function and inspect the two status assignments shown in the issue. Confirm the second assignment targets FrameError and uses the frame-error bit-field constants; done means the incorrect target is corrected and the relevant embedded software checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
embedded-iot
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.