Mistaken Sync interval timeout for calculation logMeanSyncInterval = -7

Open
#2 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
c
Domain
embedded-iot

Research direction

Start in XilinxProcessorIPLib/drivers/axiethernet/examples/avb/xavb.c at line 392, then inspect how XAvb_ConvertLogMeanToDuration handles -7 for the 128-packets-per-second option. Confirm the timeout calculation no longer produces a zero multiplier or causes an immediate timeout for that sync rate.

Written by the indexing model from the issue text.

Description

Line 392 below subtracts 1 from the interval and multiplies by the timeout factor. However, for 128 packets-per-second, logMeanSyncInterval = -7 and XAvb_ConvertLogMeanToDuration converts -7 to 1. Then, when finally 1 is subtracted in line 392, a 0 multiplies the timeout factor. Ultimately, timeout always occur for this sync rate option.

https://github.com/Xilinx/embeddedsw/blob/fff3aa272373e54930e16605de93dd02605febd4/XilinxProcessorIPLib/drivers/axiethernet/examples/avb/xavb.c#L392

Dominant language
HTML
Stars
1.2k
Forks
1.1k
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Xilinx/embeddedsw

All issues in Xilinx/embeddedsw

Similar issues

More Embedded & IoT issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.