Xilinx / Xilinx/embeddedsw

Incorrect validation of layer width

Open
#180 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
HTML
Stars
1.2k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

The validation of the layer width (not the logo layer) expects the layer window to be smaller than the hardware supports, while it should also allow exactly the hardware supported width (like for hight and for the logo layer width).
https://github.com/Xilinx/embeddedsw/blob/a8e6ff65ba32cef65062e9f3bd04e680fcb8d9bf/XilinxProcessorIPLib/drivers/v_mix/src/xv_mix_l2.c#L568

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in XilinxProcessorIPLib/drivers/v_mix/src/xv_mix_l2.c around line 568, where the non-logo layer width is validated. Compare that check with the height and logo-layer width validation, then verify that the maximum hardware-supported width is accepted while smaller and larger values retain their intended behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
embedded-iot
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.