Dangling comment in xcanfd.c::XCanFd_Send()
Open
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 1.2k
- Forks
- 1.1k
- PR merge metrics
- No merged PRs in 30d
Description
In https://github.com/Xilinx/embeddedsw/blob/master/XilinxProcessorIPLib/drivers/canfd/src/xcanfd.c#L547 we have this comment:
/* Assign buffer number to user */
*TxBufferNumber = FreeTxBuffer;
/* Make That buffer as transmitted */
return XST_SUCCESS;
Is there some missing code to "Mark that buffer as transmitted"?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in XilinxProcessorIPLib/drivers/canfd/src/xcanfd.c at the referenced XCanFd_Send() lines and inspect the surrounding transmit-buffer handling. Determine whether the dangling “Make That buffer as transmitted” comment describes missing behavior or should be removed, then verify that the final code and comment agree with the function’s behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- embedded-iot
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100