XSPI concurreny issue
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 1.2k
- Forks
- 1.1k
- PR merge metrics
- No merged PRs in 30d
Description
XSpi instance struct has a IsBusy flag, which tells if the instance handler is busy.
However this flag is incorrectly, from the concurrency point of view.
See the inmplementation of the XSpi_Transfer
It check the IsBusy, then disables the interrupts, then set the IsBusy.
This is not thread-safe, which makes the IsBusy useless.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the XSpi instance definition in XilinxProcessorIPLib/drivers/spi/src/xspi.h and trace XSpi_Transfer in XilinxProcessorIPLib/drivers/spi/src/xspi.c, especially the IsBusy check, interrupt disable, and flag update. Analyze the race between concurrent callers and determine the synchronization change needed; done means IsBusy reliably prevents overlapping transfers.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- embedded-iot
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100