strtoul in bif.l corrupts numbers larger than 2^32 on Windows
Open
Beginner friendly
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 64
- Forks
- 56
- PR merge metrics
- No merged PRs in 30d
Description
On line 277 of bif.l, strtoul is used to convert the value from a string to uint64_t.
However on Windows, unsigned long is 32 bits not 64, so strtoul will silently corrupt any value greater than 0xFFFFFFFF to that value.
The correct function should be strtoull
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open bif.l at line 277 and inspect the conversion from the string value to uint64_t, paying particular attention to Windows integer widths. The issue is done when values larger than 0xFFFFFFFF are converted without corruption using the appropriate function.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 70/100