WrenSecurity / WrenSecurity/wrenicf-java-framework

Simplify overly complex project internals

Open
#27 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
2
Forks
9
Avg merge
7h 41m
Merged PRs (30d)
1

Description

I have spent quite a lot of time working on this project. I was hesitant to create this issue because I felt like I am lacking a lot of know-how to propose such a significant change. However....

  • version 1.5 introduced protobuf
  • version 1.5 introduced websocket as transport
  • version 1.5 abstracted RPC mechanics (request / response / response stream) as an unbelievably super generic abstract thing

I think it is apparent which part of the framework I consider in need of rewrite :). The generics in framework-rpc module makes working with the project so so so so so so much harder (both in terms of understanding what is going on and in terms of source code littered with unnecessary generic parameters).

I am creating this issue to start discussion (or maybe direct efforts) on how to rewrite this part of the project.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the framework-rpc module and the changes introduced with protobuf, websocket transport, and the generic RPC abstractions. Trace how request, response, and response-stream mechanics are represented. Done would require an agreed rewrite plan, since this issue currently opens a discussion rather than defining a specific implementation or test target.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api, backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.