Workiva / Workiva/over_react

raise package upper bounds and/or migrate to Dart 3

Open
#947 8 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Dart
Stars
432
Forks
57
PR merge metrics
No merged PRs in 30d

Description

  • Issue Type: FEATURE REQUEST
  • over_react Version(s): 5.3.0

My project depends heavily on OverReact, and I finished migrating it to null safety with Dart 2.19.6. (If it matters, it's what's on the dev branch here: https://github.com/UC-Davis-molecular-computing/scadnano/tree/dev)

I thought I could then proceed to upgrade to Dart 3, but I ran into some issues that I believe are coming from package upper bounds in OverReact: https://github.com/UC-Davis-molecular-computing/scadnano/issues/990#issuecomment-2350446695 In particular, although OverReact is ostensibly compatible with Dart 3:

image

I think the package upper bounds of OverReact make this difficult. In particular (as I mention in the comment linked above) I suspect that you need frontend_server_client version 4 in order to run dart run build_runner build (or related build_runner tasks such as dart run build_runner build, or webdev serve, which I think runs dart run build_runner build behind the scenes) with Dart 3.

Maybe I'm just doing something wrong, but I wrestled with this for a while and, based on the discussion I linked in the comment (https://github.com/dart-lang/sdk/issues/55911#issuecomment-2146096571) I suspect that I won't be able to upgrade to Dart 3 until OverReact raises the package upper bounds on frontend_server_client (and perhaps others? e.g., build_runner is currently at version 2.4.12 but I ran into resolving issues, I believe related to other version upper bounds in OverReact that limits it to 2.3 for build_runner).

Sorry if this isn't the right place to put this. There used to be a gitter page that the team used (https://app.gitter.im/#/room/#over_react_Lobby:gitter.im?source=orgpage), but I'm not sure how to contact them anymore.


FYI: @greglittlefield-wf @aaronlademann-wf @kealjones-wk @evanweible-wf @maxwellpeterson-wf

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the package dependency bounds for frontend_server_client and build_runner, then reproduce the Dart 3 resolution and dart run build_runner build problems described in the issue. Done means the relevant bounds permit the requested Dart 3 workflow without dependency-resolution failures.

Written by the indexing model from the issue text.

Assessment

Tech stack
dart
Domain
build-system
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.