Workiva / Workiva/over_react

Improve the diagnostic(s) for missing parentheses around cascading prop setters

Open
#594 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area-analyzer-plugin
Dominant language
Dart
Stars
432
Forks
57
PR merge metrics
No merged PRs in 30d

Description

  • Fix: Add parentheses

This work has been completed for unambiguous cases (see: MissingCascadeParensDiagnostic), but we still need to implement:

  1. Likely cases
  2. Ambiguous cases
    • Look for this in uninvoked builder/children fix?

Transferred from https://github.com/Workiva/over_react_analyzer_plugin/issues/27

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the existing MissingCascadeParensDiagnostic implementation and tracing how diagnostics are registered for cascading prop setters. Then investigate the uninvoked builder/children fix reference for the ambiguous cases. Done means likely and ambiguous missing-parentheses cases produce the intended diagnostic and fix behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
dart
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.