Workiva / Workiva/over_react

Add test coverage for react_types utils

Open
#549 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area-analyzer-plugin
Dominant language
Dart
Stars
432
Forks
57
PR merge metrics
No merged PRs in 30d

Description

Putting this off till later...

Test is on branch link-2020/react_types_test

My test passes by adding the local file hack to the utility method I have in the test file, but not when I try and add the hack to parseAndGetResolvedUnits function and use that instead

The file should get well covered by integration tests anyway, but we may want to revisit in the future

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the test on branch link-2020/react_types_test and the parseAndGetResolvedUnits function. Compare the local file hack used by the test with the utility implementation, then check the existing integration-test coverage. Done means the react_types utilities have meaningful passing coverage without relying on the local file hack.

Written by the indexing model from the issue text.

Assessment

Tech stack
dart
Domain
testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.