WordPress / WordPress/wordpress.org

Missing labels for some form elements in wp-themes.com default demo content

Open
#823 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

[Site] Themes
Dominant language
PHP
Stars
163
Forks
221
PR merge metrics
No merged PRs in 30d

Description

On https://wp-themes.com/twentytwentyfive/?p=36 (and all themes that show that post)

I don't know what exactly is in the raw post content but putting current and proposed content below (collapsed). Basically, just some labels for checkboxes etc.

Current
<h2 id="form_elements">Forms</h2>
<fieldset>
<legend>Legend</legend>
<p>Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Nullam dignissim convallis est. Quisque aliquam. Donec faucibus. Nunc iaculis suscipit dui. Nam sit amet sem. Aliquam libero nisi, imperdiet at, tincidunt nec, gravida vehicula, nisl. Praesent mattis, massa quis luctus fermentum, turpis mi volutpat justo, eu volutpat enim diam eget metus.</p>
<form>
<h2>Form Element</h2>
<p>Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Nullam dignissim convallis est. Quisque aliquam. Donec faucibus. Nunc iaculis suscipit dui.</p>
<p><label for="text_field">Text Field:</label><br>
<input type="text" id="text_field"></p>
<p><label for="text_area">Text Area:</label><br>
<textarea id="text_area"></textarea></p>
<p><label for="select_element">Select Element:</label><br>
<select name="select_element"><br>
			<optgroup label="Option Group 1"><option value="1">Option 1</option><option value="2">Option 2</option><option value="3">Option 3</option></optgroup><br>
			<optgroup label="Option Group 2"><option value="1">Option 1</option><option value="2">Option 2</option><option value="3">Option 3</option></optgroup><br>
</select></p>
<p><label for="radio_buttons">Radio Buttons:</label></p>
<p><input type="radio" class="radio" name="radio_button" value="radio_1"> Radio 1<br>
<input type="radio" class="radio" name="radio_button" value="radio_2"> Radio 2<br>
<input type="radio" class="radio" name="radio_button" value="radio_3"> Radio 3</p>
<p><label for="checkboxes">Checkboxes:</label></p>
<p><input type="checkbox" class="checkbox" name="checkboxes" value="check_1"> Radio 1<br>
<input type="checkbox" class="checkbox" name="checkboxes" value="check_2"> Radio 2<br>
<input type="checkbox" class="checkbox" name="checkboxes" value="check_3"> Radio 3</p>
<p><label for="password">Password:</label></p>
<p><input type="password" class="password" name="password"></p>
<p><label for="file">File Input:</label><br>
<input type="file" class="file" name="file"></p>
<p><input class="button" type="reset" value="Clear"> <input class="button" type="submit" value="Submit"></p>
</form>
</fieldset>
Proposed
<h2 id="form_elements">Forms</h2>
<fieldset>
<legend>Legend</legend>
<p>Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Nullam dignissim convallis est. Quisque aliquam. Donec faucibus. Nunc iaculis suscipit dui. Nam sit amet sem. Aliquam libero nisi, imperdiet at, tincidunt nec, gravida vehicula, nisl. Praesent mattis, massa quis luctus fermentum, turpis mi volutpat justo, eu volutpat enim diam eget metus.</p>
<form>
<h2>Form Element</h2>
<p>Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Nullam dignissim convallis est. Quisque aliquam. Donec faucibus. Nunc iaculis suscipit dui.</p>
<p><label for="text_field">Text Field:</label><br>
<input type="text" id="text_field"></p>
<p><label for="text_area">Text Area:</label><br>
<textarea id="text_area"></textarea></p>
<p><label for="select_element">Select Element:</label><br>
<select name="select_element"><br>
			<optgroup label="Option Group 1"><option value="1">Option 1</option><option value="2">Option 2</option><option value="3">Option 3</option></optgroup><br>
			<optgroup label="Option Group 2"><option value="1">Option 1</option><option value="2">Option 2</option><option value="3">Option 3</option></optgroup><br>
</select></p>
<p><label for="radio_buttons">Radio Buttons:</label></p>
<p>
<label><input type="radio" class="radio" name="radio_button" value="radio_1"> Radio 1</label><br>
<label><input type="radio" class="radio" name="radio_button" value="radio_2"> Radio 2</label><br>
<label><input type="radio" class="radio" name="radio_button" value="radio_3"> Radio 3</label></p>
<p><label for="checkboxes">Checkboxes:</label></p>
<p>
<label><input type="checkbox" class="checkbox" name="checkboxes" value="check_1"> Radio 1</label><br>
<label><input type="checkbox" class="checkbox" name="checkboxes" value="check_2"> Radio 2</label><br>
<label><input type="checkbox" class="checkbox" name="checkboxes" value="check_3"> Radio 3</label></p>
<p><label for="password">Password:</label></p>
<p><input type="password" class="password" id="password" name="password"></p>
<p><label for="file">File Input:</label><br>
<input type="file" class="file" name="file" id="file"></p>
<p><input class="button" type="reset" value="Clear"> <input class="button" type="submit" value="Submit"></p>
</form>
</fieldset>

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the wp-themes.com/twentytwentyfive/?p=36 demo page and compare the Current and Proposed HTML in the issue. Trace that post’s raw content in the WordPress.org mirror; done means the radio, checkbox, password, and file controls have associated labels as shown in Proposed, and the change applies to themes showing the post.

Written by the indexing model from the issue text.

Assessment

Tech stack
html
Domain
accessibility, content
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.