WordPress / WordPress/wordpress-playground
PHP: Don't catch all the errors in Dockerfile, catch only specific exit codes
Open
Nobody has claimed this yet.
[Feature] PHP.wasm
[Type] Developer Experience
[Type] Enhancement
- Dominant language
- JavaScript
- Stars
- 2k
- Forks
- 462
- Avg merge
- 18h 44m
- Merged PRs (30d)
- 33
Description
This line tolerates all the errors:
Let's check the status code and only accept a specific one:
|| echo $?
#!/bin/env bash
shasum -c ''
echo $?
2
if [[ 2 -eq $? ]]; then
blahblah
fi;
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect packages/php-wasm/compile/Dockerfile at the linked line and identify the command whose failure is currently ignored. Run the relevant Docker build, then verify that the intended exit code is accepted while other failures cause the build to fail.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, shell, wasm
- Domain
- build-system, devops
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100