WordPress / WordPress/wordpress-playground
PHP: Build with pthreads support
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 2k
- Forks
- 462
- Avg merge
- 18h 44m
- Merged PRs (30d)
- 33
Description
Pthreads are required to run the pcntl extensions and functions like pcntl_fork and pcntl_exec. Full PHPUnit support hinges on this, and AFAIR there's a few wp-cli commands also relying on threads.
Turns out supporting pthreads offers no clear benefit as WordPress-related PHP libraries typically don't require it. What wp-cli and PHPunit both need is proc_open.
The implementation is explored in https://github.com/WordPress/wordpress-playground/pull/346
Related:
- https://wiki.php.net/rfc/native-tls
- https://github.com/WordPress/playground-tools/issues/25
- http://blog.jpauli.tech/2017-01-12-threads-and-php-html/
- https://stackoverflow.com/questions/49539849/php-internals-how-does-tsrmls-fetch-work
- https://phpinternals.net/categories/extensions#zend-globals
cc @dmsnell @danielbachhuber @sejas
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read the issue update, PR #346, and related issue #594 before starting. The original pthreads request is described as offering no clear benefit, while proc_open is identified as the need for wp-cli and PHPUnit; the current implementation target therefore needs clarification or superseding work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php, wasm
- Domain
- backend, build-system
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 15/100