WordPress / WordPress/theme-check

Generic tokenizer checking

Open
#87 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
371
Forks
113
Avg merge
8m
Merged PRs (30d)
5

Description

The checks using regex ain't great. For some checks like the recent text domain checks, the tokenizer was used. This can be made more generalized, to allow the tokenizer data to be only made once and then given to several checks.

This is a general issue to track the idea of using the tokenizer in multiple checks, and having the actual token process in the main check system instead of in each check.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are identified in the issue. Start by tracing how tokenizer data is created in the existing text-domain checks and how checks are coordinated; done means the tokenizer is created once by the main check system and its data can be reused by multiple checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.