WordPress / WordPress/theme-check

Text Domain Check False Positive on Child Theme

Open
#480 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
371
Forks
113
Avg merge
8m
Merged PRs (30d)
5

Description

https://github.com/WordPress/theme-check/blob/master/checks/class-textdomain-check.php

The regex seems to be picking up the "Template:" tag in style.css and incorrectly parsing it as a textdomain.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in checks/class-textdomain-check.php and inspect the regex that processes the child theme's style.css. Reproduce the check with a style.css containing a "Template:" tag, then confirm that the tag is no longer parsed as a textdomain and that legitimate textdomains are still detected.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.