WordPress / WordPress/theme-check

Improve consistency and naming of variables

Open
#384 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
371
Forks
113
Avg merge
8m
Merged PRs (30d)
5

Description

Throughout the checks, different variable names are used even though the purpose is the same.
For example some checks use
foreach ( $php_files as $php_key => $phpfile ) {
while others use a clearer name:
foreach ( $php_files as $file_path => $file_content ) {

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the theme-check checks for variables serving the same purpose as the $php_files example, and identify the naming convention to apply consistently. The work is done when equivalent variables use consistent, descriptive names throughout the checks; no specific files or tests are named in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.