WordPress / WordPress/sqlite-database-integration

Fatal errors with "show variables like X" queries

Open
#34 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
363
Forks
67
Avg merge
2d 15h
Merged PRs (30d)
7

Description

I'm testing the sqlite-database integration plugin on a production site, where I have (amongs other plugins) Wordfence installed.

While I managed to workaround a previous issue I submitted (see #32 ) by installing a more recent version of SQLite, today I found an issue that doesn't have such an easy workaround.

At some point, Wordfence executes SQL statements like show variables like 'max_allowed_packet' (see https://plugins.trac.wordpress.org/browser/wordfence/trunk/lib/wfDB.php#L146) and the SQLite database integration plugin throws a fatal error, as SQLite doesn't know how to handle such statement.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Wordfence query shown in lib/wfDB.php at line 146 and reproduce show variables like 'max_allowed_packet' through the SQLite database integration plugin. Inspect how unsupported SQL statements are handled; done means this query no longer causes a fatal error while preserving the plugin's SQLite compatibility.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, sqlite
Domain
backend, databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.