WordPress / WordPress/sqlite-database-integration

Table engine support

Open
#191 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
363
Forks
67
Avg merge
2d 15h
Merged PRs (30d)
7

Description

Currently, the SQLite driver saves the specified table engine in the information schema, but it doesn't emulate different engine behavior in any way, nor it checks whether the engine is supported. At the moment, we expect the engine to be InnoDB.

WordPress also works with MyISAM, and there are other table engines in MySQL.

We probably could implement support for some additional engines (ignore FKs for MyISAM, etc.), but until then, we can trigger a warning when an engine other than InnoDB is used.

Additionally, we should make the warnings configurable:

These warnings will quickly get annoying so we could add a driver-level warning control with an option such as "warnings" => array( "db_engine" => true|false, ... )

See also: https://github.com/Automattic/sqlite-database-integration/pull/21#discussion_r1980080528

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the SQLite driver code that stores table-engine metadata and review how it currently treats InnoDB. Then trace the driver-level option handling and any existing warning paths. Done means the intended handling for unsupported engines, including MyISAM behavior or warnings, is defined and warning controls are covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
mysql, php, sqlite
Domain
databases
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.