WordPress / WordPress/plugin-check

Centralize usage of `Runtime_Environment_Setup`

Open
#128 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

[Type] Enhancement Code Quality
Dominant language
PHP
Stars
362
Forks
126
Avg merge
1d 23h
Merged PRs (30d)
22

Description

Is your enhancement related to a problem? Please describe.

Both the Admin_AJAX and Plugin_Check_Command class currently manually use the Runtime_Environment_Setup class, and both of them for that reason also have a check whether any of the checks is a Runtime_Check.

This is not very clean and we should explore ways to consolidate that code in one place in a way that both Admin_AJAX and Plugin_Check_Command can use it.

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct
  • I agree to follow this project's Code of Conduct

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading Admin_AJAX, Plugin_Check_Command, and Runtime_Environment_Setup to compare how each class performs setup and checks for Runtime_Check instances. Determine a shared approach that both entry points can use without duplicating that logic. Done means the duplicated setup and Runtime_Check checks are centralized and both classes continue to support their existing checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.