WordPress / WordPress/plugin-check-action

Request: Do not update plugin-check silently without a new version of this action

Open
#527 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
TypeScript
Stars
129
Forks
17
PR merge metrics
No merged PRs in 30d

Description

Hi,
I am using this action to run plugin-check on my WP plugin repos. However, if I understand it correctly, this action upgrades (i.e. uses the latest) plugin-check without a new version release to this action.

Why this is a problem:

  • On December 27, plugin-check released version 1.8.0, which brings in a lot of new checks
  • However, the direct_file_access check has some significant omissions - in my case WordPress/plugin-check#1146
  • Because the action just uses the latest version of plugin-check, all my PRs have been failing CI since Dec 27.

I don't really see any good way out of this - I can:

  1. Just live with broken CI for 2 months and going
  2. Disable this action until plugin-check fixes the issues and hope I remember to re-enable it afterwards

...neither of which is a good option. I have dependabot set up, so all my dependency updates fail CI and I have to review them manually.

If this action pinned the plugin-check version it uses (and bump versions with new plugin-check versions), the problem would be solved - I could just postpone the update of plugin-check, make the upgrade when I have the bandwidth to deal with it and when it works the way I need. The current state is a much worse DX.

Just to make sure - I'm not complaining about plugin-check not implementing WordPress/plugin-check#1146 right away. Issues happen, sometimes they take longer to sort out, that's okay. But I'd like to not be forced to deal with the issue (or just the update itself, even if it's completely fine, it can still take time to update) the second a new version is available.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how the plugin-check action selects its dependency version and how action releases are versioned. Verify the completed change keeps plugin-check on an explicit version and allows updates through new action releases, then run the repository's existing CI checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, typescript
Domain
ci-cd, developer-experience, tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
62/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.