WordPress / WordPress/php-toolkit
Discussion: handling of PHP version / os dependent results
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 61
- Forks
- 21
- Avg merge
- 19h 34m
- Merged PRs (30d)
- 7
Description
I've noticed that the RunWordPressInstallerStepRunner returns different success messages for different PHP versions.
For PHP <= 7.3 it returns:
#!/usr/bin/env php\n
Success: WordPress installed successfully.
And for PHP > 7.3 it returns:
Success: WordPress installed successfully.
That's just a small / funny wp-cli quirk and it is quite easy to handle, yet it begs a crucial question - should we take the responsibility of delivering unified responses for all PHP / os versions?
Keeping huge ambitions for playground and blueprints in mind, not taking the burden at code level will inevitably push it to support / end users. Although it may look like a nitpick today, it won't take long until this will start causing real-life problems. So, I'd recommend we include a design principle to... care about this... I guess.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the RunWordPressInstallerStepRunner entry point and compare its reported output across the PHP versions described in the issue. The discussion does not identify files, tests, or a settled design; work is complete only once the project has agreed on whether and how version- and OS-dependent responses should be unified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100