WordPress / WordPress/php-toolkit

Windows compatibility: proper path canonicalization for all os versions and cases

Open
#66 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
PHP
Stars
61
Forks
21
Avg merge
19h 34m
Merged PRs (30d)
7

Description

As part of the windows compatibility effort a question arose regarding proper canonicalization of paths. To quote @adamziel in a discussion on Symfony's Path method canonicalize:

I'm not sure this is the right approach as it will turn C:\Program Files\Stuff into C:/Program Files/Stuff. It might be fine but I'm not sure if it will universally work with all Windows versions and paths, e.g. what about network shared directories such as \\NetDirectory\SubPath?

Let's take a moment to analyze all potential use cases and establish a solid way to resolve all links on windows.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the existing path canonicalization entry point and documenting the Windows cases raised here, including drive-letter paths and network shares. Compare expected behavior across Windows versions and path forms, then define a canonicalization approach with coverage for each case before implementation.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
operating-systems
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.