WordPress / WordPress/openverse
Stop the e2e test suite if talkback proxy fails to start
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 380
- Forks
- 290
- Avg merge
- 3h 17m
- Merged PRs (30d)
- 8
Description
Problem
The script that runs a proxy server alongside our e2e test suite was added in WordPress/openverse-frontend#881. If for any reason talkback fails to start (for example if there's something already running on port 3000) then the e2e tests still run.
Description
If talkback fails to start, the whole test run should stop (fail).
Adding the typical fast-fail mechanisms won't work because we're using & to capture the PID, we'll need specific error handling for that case 😕
(From the #881 comment)
Implementation
- 🙋 I would be interested in implementing this feature.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the script that launches the talkback proxy alongside the e2e suite, and trace how its background PID and startup result are handled. Reproduce a failed proxy start, such as when port 3000 is already in use, then verify that the e2e run fails instead of continuing.
Written by the indexing model from the issue text.
Assessment
- Domain
- testing
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100