WordPress / WordPress/openverse
Make `license_url` a non-optional media property
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 380
- Forks
- 290
- Avg merge
- 3h 17m
- Merged PRs (30d)
- 8
Description
Blocked by the work in the Catalog and API.
Problem
Currently, we set the license_url as an optional property for media, but it should be available for all media items.
Description
After normalizing the data in the catalog/API, we should set it as required.
https://github.com/WordPress/openverse-frontend/blob/fd2c7fba20b48535981dcd1167ce0ea3799fb36a/src/models/media.ts#L24
https://github.com/WordPress/openverse/blob/8ee33a66bfb2edc9284f0653d956d3dc8a4b6481/frontend/src/types/media.ts#L30
Implementation
- 🙋 I would be interested in implementing this feature.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with frontend/src/types/media.ts at line 30 and review the catalog/API normalization work that blocks this issue. Confirm that normalized media data guarantees license_url, then make the type reflect that requirement. Done means the frontend type and the normalized data contract agree.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api, frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100