WordPress / WordPress/gutenberg

Navigation conversion scenarios need comprehensive entity binding coverage

Open
#72,425 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

[Block] Navigation [Block] Page List
Dominant language
JavaScript
Stars
11.8k
Forks
4.9k
PR merge metrics
PR metrics pending

Description

What

Navigation conversion processes need comprehensive coverage to ensure entity bindings are properly created for dynamic URL resolution across all conversion scenarios.

Why

Currently, there are multiple conversion paths that create Navigation Link blocks but don't include the required entity bindings for dynamic URL resolution. This causes converted links to lose their connection to underlying page entities, breaking the dynamic URL functionality introduced in #71630.

Conversion Scenarios That Need Coverage

1. Page List to Navigation Link conversion
  • Status: Fixed in PR #72287
  • Issue: Page List blocks converted to Navigation Links were missing entity bindings
  • Impact: Links lose dynamic URL resolution when page URLs change
2. Classic Menu to Navigation Link conversion
  • Status: Fixed in PR #72289
  • Issue: Classic Menu items converted to Navigation Links were missing entity bindings
  • Impact: Links lose dynamic URL resolution when page URLs change

How

  1. Audit all conversion paths that create Navigation Link blocks
  2. Ensure entity bindings are included in all conversion scenarios
  3. Create shared utilities for consistent entity binding creation
  4. Add comprehensive test coverage for all conversion scenarios
  5. Document conversion requirements for third-party developers

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by auditing conversion paths that create Navigation Link blocks, using the entity-binding behavior introduced in #71630 and the fixes in #72287 and #72289 as references. The work is done when all conversion scenarios preserve entity bindings, have comprehensive tests, and the conversion requirements are documented for third-party developers.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
documentation, frontend, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.