WordPress / WordPress/grunt-patch-wordpress
Inaccurate output from grunt patch command
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 51
- Forks
- 13
- PR merge metrics
- No merged PRs in 30d
Description
Via @johnbillion in https://core.trac.wordpress.org/ticket/32717
$ grunt patch:28180
Running "patch:28180" (patch) task
[?] Please select a patch to apply: language_attributes.28180.diff (2.7 KB) - added by posykrat 11 hours ago.
patch unexpectedly ends in middle of line
patch: **** Only garbage was found in the patch input.
Done, without errors.
The "Done, without errors" line is incorrect.
Can this be improved?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the grunt patch:28180 command and inspect the patch task's handling of the failed patch process. Done means the command no longer reports "Done, without errors" when patch reports an error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- cli, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100