WordPress / WordPress/grunt-patch-wordpress
The interactive prompt doesn't support src/ as a base path
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 51
- Forks
- 13
- PR merge metrics
- No merged PRs in 30d
Description
In e3013dbfa2bd6b64d7b45c5f34f5b5123acaf364, you added the ability to interact with the prompt in the case where a file couldn't be found for patching. And this fixed #21.
However, in attempting to apply a patch today, I noticed that when interacting with the prompt, it would not allow me to specify the file path beginning with src/, only wp-*, in this case wp-includes/.
Seems like we'd want to cover the src/ case in the instance where files might fall in the root directory, not to mention, this is packaged with develop, so I'd expect it to work with src/ as a base path.
To reproduce, try applying post-thumbnail-comment-patch.diff via 31351 from the root directory, specifying the path src/wp-includes/post-thumbnail-template.php
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue from the repository root by applying post-thumbnail-comment-patch.diff via 31351 and entering src/wp-includes/post-thumbnail-template.php. Trace the interactive prompt's path handling, then verify that a src/ base path is accepted and the patch applies successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- cli, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100