WordPress / WordPress/create-block-theme

Typography tab persistence

Open
#840 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Edit Theme settings enhancement
Dominant language
JavaScript
Stars
417
Forks
66
PR merge metrics
No merged PRs in 30d

Description

Part of #836. Wires the Typography tab. Depends on the Color/foundation PR.

Scope

  • TypographySettingsPanelsettings.typography.* (flag fields)
  • FontFamiliesPanelsettings.typography.fontFamilies (deepest nested shape — fontFace arrays per family)
  • FontSizesPanelsettings.typography.fontSizes

Acceptance criteria

  • Adding a font family with multiple fontFace entries persists with the correct nested structure.
  • Removing a family removes both the entry and any associated font assets reference (no orphaned assets if theme-fonts.php is involved — confirm during implementation).
  • Standard loading / success / error UX.

Out of scope

  • Font asset upload / management (existing flow in theme-fonts.php is separate).

References

  • Tracking issue: #836

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read TypographySettingsPanel, FontFamiliesPanel, and FontSizesPanel to trace how each maps to the settings structure, starting with the deepest fontFace array shape. Verify loading, success, and error behavior, and confirm theme-fonts.php handling when removing a family. Done means nested typography settings persist correctly, removed families leave no orphaned asset references, and the standard UX works.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
62/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.